Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile for build process #128

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

landabaso
Copy link
Contributor

@landabaso landabaso commented Jul 25, 2023

In this PR, I have made the following changes to the Dockerfile:

  • Git submodules are now initialized during the binaryen installation process.
  • Rust installation has been modified to use the version specified in the ./rust-toolchain file, replacing the previously used default stable version.
  • Additional Rust components and target are installed based on the version in ./rust-toolchain.
  • The rust-toolchain file is removed after installation to maintain a clean working directory.

Fixes #127

Details:
- Initialized git submodules in binaryen installation process.
- Altered Rust installation to use the version specified in ./rust-toolchain, instead of the default stable version.
- Installed additional components and target using ./rust-toolchain version.
- Removed rust-toolchain after installation to maintain a clean working directory.
Dockerfile Show resolved Hide resolved
…lation process to automatically fetch the correct Rust version, simplifying commands
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM utACK. We can fix it in later PRs if it still has issues.

@junderw junderw merged commit 8671d1d into bitcoinjs:master Jul 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Build Failure
2 participants