Nested headings for Transcript Page #75
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Emmanuel-Develops
force-pushed
the
staging
branch
from
f5e214e to
358e47a
Compare
|
Hello @0tuedon can you please rebase your branch to the latest on staging to resolve merge conflicts |
0tuedon
force-pushed
the
nested-heading
branch
from
34484c1 to
259d044
Compare
|
This new commit cb3712c is meant to changed the complex data structure we had for Content Page and Content Grouping. This should resolve comments made by @kouloumos and @Emmanuel-Develops. There might still be some nit fixes and I will need extra eyes on this. |
0tuedon
force-pushed
the
nested-heading
branch
from
cb3712c to
67eb2d1
Compare
| @@ -32,14 +32,12 @@ const TranscriptContentPage: FC<ITranscriptContentPage> = ({ | |||
| linkName, | |||
| type, | |||
| }) => { | |||
| // [{name: "A", slug:"a", nested: [{name: "ABC", count: 1}]}] | |||
There was a problem hiding this comment.
We can remove commented out code here
There was a problem hiding this comment.
This was to explain the format and dataStructure the functions below will return
There was a problem hiding this comment.
Ohhhh. Please can you add a comment explaining that ?
| color: #000; | ||
| font-size: 1rem | ||
| scroll-margin-top: 100px; |
There was a problem hiding this comment.
As this is the only line of change, this should be what is reflected in this change but I think your prettier formatting options added some extra changes
|
While reviewing the PR, I tested the links in the example transcript tagged in the PR description and I noticed that clicking on them don't navigate you to a new page while retaining the bitcoin transcripts in its own tab but you're routed to the page inside the existing transcript page hence taking you out of the app. Is this the expected behaviour we want when we click on external links when reading a transcript ? @0tuedon @Emmanuel-Develops @kouloumos My concern is when you route a user inside the same tab, there is a tendency they will continue to explore other materials without going back to the app. But when the link is opened in a new tab, you are sure after the user has explored new information from the external link, they can comeback to reading the transcript as the tab still exists and no new information has been added to url history state. |
Oh yh I agree this can be done, not sure if I asked the question before (looks familiar) waiting for confirmation from @kouloumos and @Emmanuel-Develops . |
its a nit we can address in dev-design call. @0tuedon I noticed there is no hover state for the nested links |
Yh messaged tobi last week let me remind him |
0tuedon
force-pushed
the
nested-heading
branch
from
f48b33e to
cc81716
Compare
Emmanuel-Develops
force-pushed
the
staging
branch
from
5fc22f8 to
1825a2c
Compare
0tuedon
force-pushed
the
nested-heading
branch
from
cc81716 to
772d294
Compare
…rouping and Transcript content page
0tuedon
force-pushed
the
nested-heading
branch
from
772d294 to
56d51b5
Compare
Emmanuel-Develops
merged commit dd24d3c
into
bitcointranscripts:staging
This PR adds support for nested transcript navigation chapters and closes issue #64 .
You can Test with this link