Handle missing schemas in ensure_up! #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed that `c:Migrator.ensure_up!/0` does not check for existence of schemas before calling `Ecto.Migrator.migrations/3`, which unfortunately terminates with a rather cryptic error. This PR fixes that by explicitly checking schema existence before calling `migrations/3`. Opted for only checking (instead of creating it) to keep `ensure_up!/0`'s behaviour "read-only".
maltoe
force-pushed
the
handle-missing-schemas-in-ensure-up
branch
from
9a66c18
to
0e1482c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that
c:Migrator.ensure_up!/0does not check for existence of schemas before callingEcto.Migrator.migrations/3, which unfortunately terminates with a rather cryptic error.This PR fixes that by explicitly checking schema existence before calling
migrations/3. Opted for only checking (instead of creating it) to keepensure_up!/0's behaviour "read-only".Unfortunately no test coverage as
Migratorisn't tested at all, but I promise I've tested it locally.