[#96] Use u-height-stretch instead of… #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u-height-100vh in sidebar #96
andreasknoepfle
force-pushed
the
feature/96-use-u-height-stretch-instead-of-u-height-100vh-in-sidebar
branch
from
6000148
to
8a07290
Compare
andreasknoepfle
commented
Dec 14, 2022
| @@ -71,7 +71,8 @@ defmodule BitstylesPhoenixDemo.MixProject do | |||
| ], | |||
| bitstyles: [ | |||
| "cmd mkdir -p priv/static/assets", | |||
| "cmd cp -R assets/node_modules/bitstyles/assets/* priv/static/assets" | |||
| "cmd cp -R assets/node_modules/bitstyles/assets/* priv/static/assets", | |||
| "cmd cp -R ../assets/logo.svg priv/static/assets/images/" | |||
There was a problem hiding this comment.
side thing, since the demo app image is broken
planktonic
reviewed
Dec 14, 2022
|
I just pushed a commit with updated classnames — it works for me in safari, firefox, and chrome, with or without autoprefixer (the extra niceness of I think the autoprefixer flag is unnecessary in this case, wdyt? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…u-height-100vh in sidebar
#96