Skip to content

Commit

Permalink
Fix test image setup (#289)
Browse files Browse the repository at this point in the history
- Update docker/* GH actions to their latest versions to get rid of
  warning about the `save-state` command
- Only build images if their Dockerfile has changed
- Drop Debian bullseye & bookworm images as their chromium & ghostscript
  versions have been updated to 120 and 10.0 for security reasons and we
  lost the old images
  • Loading branch information
maltoe authored Dec 13, 2023
1 parent 9bd78cf commit ed525c2
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 86 deletions.
40 changes: 0 additions & 40 deletions .github/docker/Dockerfile_debian-bookworm

This file was deleted.

40 changes: 0 additions & 40 deletions .github/docker/Dockerfile_debian-bullseye

This file was deleted.

15 changes: 12 additions & 3 deletions .github/workflows/publish-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,30 @@ jobs:
packages: write
strategy:
matrix:
dockerfile: ['elixir-1-11', 'debian-buster', 'debian-bullseye', 'debian-bookworm', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']
dockerfile: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']

steps:
- name: Checkout repository
uses: actions/checkout@v3

- uses: dorny/paths-filter@v2
id: paths-filter
with:
filters: |
dockerfile:
- .github/docker/Dockerfile_${{matrix.dockerfile}}
- name: Log in to the Container registry
uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9
if: steps.paths-filter.outputs.dockerfile == 'true'
uses: docker/login-action@v3
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Build and push Docker image
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
if: steps.paths-filter.outputs.dockerfile == 'true'
uses: docker/build-push-action@v5
with:
context: .
file: .github/docker/Dockerfile_${{matrix.dockerfile}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
name: ${{ matrix.tag }}
strategy:
matrix:
tag: ['elixir-1-11', 'debian-buster', 'debian-bullseye', 'debian-bookworm', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']
tag: ['elixir-1-11', 'debian-buster', 'alpine-3-16-2', 'alpine-3-17-3', 'alpine-3-18-4']
env:
MIX_ENV: test
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ ChromicPDF is tested in the following configurations:
| 1.15.7 | 26.2 | Alpine 3.18 | 119.0.6045.159 | 10.02.0 |
| 1.14.5 | 25.3.1 | Alpine 3.17 | 112.0.5615.165 | 10.01.1 |
| 1.14.0 | 25.1 | Alpine 3.16 | 102.0.5005.182 | 9.56.1 |
| 1.15.4 | 26.0.2 | Debian Bookworm | 115.0.5790.170 | 10.00.0 |
| 1.14.0 | 25.1 | Debian Bullseye | 108.0.5359.94 | 9.53.3 |
| 1.14.0 | 25.1 | Debian Buster | 90.0.4430.212-1 | 9.27 |
| 1.11.4 | 22.3.4.26 | Debian Buster | 90.0.4430.212-1 | 9.27 |

Expand Down

0 comments on commit ed525c2

Please sign in to comment.