Make ChromeRunner.version/0 optional in Template #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the call to `ChromeRunner.version/0` optional in `Template` to allow people who use a non-standard `:chrome_executable` to also use the `Template` (by specifying the zoom explicitly). Unfortunately, taking the `:chrome_executable` into account is quite annoying in the template opts, so we may instead just want to document this better. Users can also set the application env key explicitly before running chromic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the call to
ChromeRunner.version/0optional inTemplateto allow people who use a non-standard:chrome_executableto also use theTemplate(by specifying the zoom explicitly). Unfortunately, taking the:chrome_executableinto account is quite annoying in the template opts, so we may instead just want to document this better. Users can also set the application env key explicitly before running chromic.