bitfinexcom · ZioFabry · Jan 2, 2023 · Jan 5, 2023 · Aug 5, 2023 · Aug 5, 2023
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,20 +1,10 @@
-# 1.8.1
-- fix: Add extra Weighted Averages fields for trades timestamps
+#1.6.4
+- fix: added missing aff_code in updateOrder
 
-# 1.8.0
-- feature: Weighted Averages model
-
-# 1.7.1
-- fix: Change FundingOffer, Order, Position model to support new rest api signature
-- fix: Test coverage to support new rest api signature
-
-# 1.7.0
-- feature: Currency Movement Info model
-
-# 1.6.3
+#1.6.3
 - fix: public trade unserializing from snapshot
 
-# 1.6.2
+#1.6.2
 - feature: visible on hit option supported for hidden orders
 
 # 1.6.0

diff --git a/docs/AccountSummary.html b/docs/AccountSummary.html
diff --git a/docs/Alert.html b/docs/Alert.html
diff --git a/docs/AuthPermission.html b/docs/AuthPermission.html
diff --git a/docs/BalanceInfo.html b/docs/BalanceInfo.html
diff --git a/docs/Candle.html b/docs/Candle.html
diff --git a/docs/ChangeLog.html b/docs/ChangeLog.html
diff --git a/docs/CoreSettings.html b/docs/CoreSettings.html
diff --git a/docs/Currency.html b/docs/Currency.html
diff --git a/docs/FundingCredit.html b/docs/FundingCredit.html
diff --git a/docs/FundingInfo.html b/docs/FundingInfo.html
diff --git a/docs/FundingLoan.html b/docs/FundingLoan.html
diff --git a/docs/FundingOffer.html b/docs/FundingOffer.html
diff --git a/docs/FundingTicker.html b/docs/FundingTicker.html
diff --git a/docs/FundingTickerHist.html b/docs/FundingTickerHist.html
diff --git a/docs/FundingTrade.html b/docs/FundingTrade.html
diff --git a/docs/Invoice.html b/docs/Invoice.html
diff --git a/docs/LedgerEntry.html b/docs/LedgerEntry.html
diff --git a/docs/Liquidations.html b/docs/Liquidations.html
diff --git a/docs/Login.html b/docs/Login.html
diff --git a/docs/MarginInfo.html b/docs/MarginInfo.html
diff --git a/docs/Model.html b/docs/Model.html
diff --git a/docs/Movement.html b/docs/Movement.html
diff --git a/docs/MovementInfo.html b/docs/MovementInfo.html
diff --git a/docs/Notification.html b/docs/Notification.html
diff --git a/docs/Order.html b/docs/Order.html
diff --git a/docs/OrderBook.html b/docs/OrderBook.html
diff --git a/docs/Position.html b/docs/Position.html
diff --git a/docs/PublicPulseProfile.html b/docs/PublicPulseProfile.html
diff --git a/docs/PublicTrade.html b/docs/PublicTrade.html
diff --git a/docs/PulseMessage.html b/docs/PulseMessage.html
diff --git a/docs/StatusMessagesDeriv.html b/docs/StatusMessagesDeriv.html
diff --git a/docs/SymbolDetails.html b/docs/SymbolDetails.html
diff --git a/docs/Trade.html b/docs/Trade.html
diff --git a/docs/TradingTicker.html b/docs/TradingTicker.html
diff --git a/docs/TradingTickerHist.html b/docs/TradingTickerHist.html
diff --git a/docs/TransactionFee.html b/docs/TransactionFee.html
diff --git a/docs/UserInfo.html b/docs/UserInfo.html
diff --git a/docs/Wallet.html b/docs/Wallet.html
diff --git a/docs/WalletHist.html b/docs/WalletHist.html
diff --git a/docs/WeightedAverages.html b/docs/WeightedAverages.html
diff --git a/docs/account_summary.js.html b/docs/account_summary.js.html
diff --git a/docs/alert.js.html b/docs/alert.js.html
diff --git a/docs/auth_permission.js.html b/docs/auth_permission.js.html
diff --git a/docs/balance_info.js.html b/docs/balance_info.js.html
diff --git a/docs/candle.js.html b/docs/candle.js.html
diff --git a/docs/change_log.js.html b/docs/change_log.js.html
diff --git a/docs/core_settings.js.html b/docs/core_settings.js.html
diff --git a/docs/currency.js.html b/docs/currency.js.html
diff --git a/docs/funding_credit.js.html b/docs/funding_credit.js.html
diff --git a/docs/funding_info.js.html b/docs/funding_info.js.html
diff --git a/docs/funding_loan.js.html b/docs/funding_loan.js.html
diff --git a/docs/funding_offer.js.html b/docs/funding_offer.js.html
diff --git a/docs/funding_ticker.js.html b/docs/funding_ticker.js.html
diff --git a/docs/funding_ticker_hist.js.html b/docs/funding_ticker_hist.js.html
diff --git a/docs/funding_trade.js.html b/docs/funding_trade.js.html
diff --git a/docs/global.html b/docs/global.html
diff --git a/docs/index.html b/docs/index.html
diff --git a/docs/invoice.js.html b/docs/invoice.js.html
diff --git a/docs/ledger_entry.js.html b/docs/ledger_entry.js.html
diff --git a/docs/liquidations.js.html b/docs/liquidations.js.html
diff --git a/docs/login.js.html b/docs/login.js.html
diff --git a/docs/margin_info.js.html b/docs/margin_info.js.html
diff --git a/docs/model.js.html b/docs/model.js.html
diff --git a/docs/movement.js.html b/docs/movement.js.html
diff --git a/docs/movement_info.js.html b/docs/movement_info.js.html
diff --git a/docs/notification.js.html b/docs/notification.js.html
diff --git a/docs/order.js.html b/docs/order.js.html
diff --git a/docs/order_book.js.html b/docs/order_book.js.html
diff --git a/docs/position.js.html b/docs/position.js.html
diff --git a/docs/public_pulse_profile.js.html b/docs/public_pulse_profile.js.html
diff --git a/docs/public_trade.js.html b/docs/public_trade.js.html
diff --git a/docs/pulse_message.js.html b/docs/pulse_message.js.html
diff --git a/docs/status_messages_deriv.js.html b/docs/status_messages_deriv.js.html
diff --git a/docs/symbol_details.js.html b/docs/symbol_details.js.html
diff --git a/docs/trade.js.html b/docs/trade.js.html
diff --git a/docs/trading_ticker.js.html b/docs/trading_ticker.js.html
diff --git a/docs/trading_ticker_hist.js.html b/docs/trading_ticker_hist.js.html
diff --git a/docs/transaction_fee.js.html b/docs/transaction_fee.js.html
diff --git a/docs/user_info.js.html b/docs/user_info.js.html
diff --git a/docs/util_assign_from_collection_or_instance.js.html b/docs/util_assign_from_collection_or_instance.js.html
diff --git a/docs/util_is_collection.js.html b/docs/util_is_collection.js.html
diff --git a/docs/validators_amount.js.html b/docs/validators_amount.js.html
diff --git a/docs/validators_array.js.html b/docs/validators_array.js.html
diff --git a/docs/validators_bool.js.html b/docs/validators_bool.js.html
diff --git a/docs/validators_currency.js.html b/docs/validators_currency.js.html
diff --git a/docs/validators_date.js.html b/docs/validators_date.js.html
diff --git a/docs/validators_number.js.html b/docs/validators_number.js.html
diff --git a/docs/validators_object.js.html b/docs/validators_object.js.html
diff --git a/docs/validators_price.js.html b/docs/validators_price.js.html
diff --git a/docs/validators_string.js.html b/docs/validators_string.js.html
diff --git a/docs/validators_symbol.js.html b/docs/validators_symbol.js.html
diff --git a/docs/wallet.js.html b/docs/wallet.js.html
diff --git a/docs/wallet_hist.js.html b/docs/wallet_hist.js.html
diff --git a/docs/weighted_averages.js.html b/docs/weighted_averages.js.html
diff --git a/lib/funding_offer.js b/lib/funding_offer.js
@@ -98,7 +98,7 @@ class FundingOffer extends Model {
       throw new Error('no API interface provided')
     }
 
-    return apiInterface.submitFundingOffer({ offer: this }).then((offerArray) => {
+    return apiInterface.submitFundingOffer(this).then((offerArray) => {
       Object.assign(this, FundingOffer.unserialize(offerArray))
       return this
     })
@@ -115,7 +115,7 @@ class FundingOffer extends Model {
       throw new Error('no API interface provided')
     }
 
-    return apiInterface.cancelFundingOffer({ id: this.id }).then((offerArray) => {
+    return apiInterface.cancelFundingOffer(this.id).then((offerArray) => {
       Object.assign(this, FundingOffer.unserialize(offerArray))
       return this
     })

diff --git a/lib/index.js b/lib/index.js
@@ -25,7 +25,6 @@ module.exports = {
   LedgerEntry: require('./ledger_entry'),
   Liquidations: require('./liquidations'),
   Movement: require('./movement'),
-  MovementInfo: require('./movement_info'),
   UserInfo: require('./user_info'),
   Currency: require('./currency'),
   StatusMessagesDeriv: require('./status_messages_deriv'),
@@ -39,7 +38,6 @@ module.exports = {
   AccountSummary: require('./account_summary'),
   AuthPermission: require('./auth_permission'),
   CoreSettings: require('./core_settings'),
-  WeightedAverages: require('./weighted_averages'),
 
   isCollection: require('./util/is_collection')
 }
diff --git a/lib/movement_info.js b/lib/movement_info.js
diff --git a/lib/order.js b/lib/order.js
@@ -388,6 +388,11 @@ class Order extends Model {
 
     changes.id = this.id // tag with ID
 
+    if (_isString(this.affiliateCode) && !_isEmpty(this.affiliateCode)) {
+      changes.meta = {};
+      changes.meta.aff_code = this.affiliateCode // eslint-disable-line
+    }
+
     if (changes.price) changes.price = preparePrice(changes.price)
     if (changes.amount) changes.amount = prepareAmount(changes.amount)
     if (changes.delta) changes.delta = prepareAmount(changes.delta)
@@ -482,7 +487,7 @@ class Order extends Model {
       throw new Error('no API interface provided')
     }
 
-    const orderArr = await apiInterface.submitOrder({ order: this })
+    const orderArr = await apiInterface.submitOrder(this)
     Object.assign(this, Order.unserialize(orderArr))
     return this
   }
@@ -497,7 +502,7 @@ class Order extends Model {
     if (!apiInterface) throw new Error('no API interface provided')
     if (!this.id) throw new Error('order has no ID')
 
-    return apiInterface.cancelOrder({ id: this.id })
+    return apiInterface.cancelOrder(this.id)
   }
 
   /**

diff --git a/lib/position.js b/lib/position.js
@@ -85,7 +85,7 @@ class Position extends Model {
       throw new Error('claim position only supported on RESTv2')
     }
 
-    return apiInterface.claimPosition({ id: this.id }).then((positionArray) => {
+    return apiInterface.claimPosition(this.id).then((positionArray) => {
       Object.assign(this, Position.unserialize(positionArray))
       return this
     })

diff --git a/lib/weighted_averages.js b/lib/weighted_averages.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "bfx-api-node-models",
-  "version": "1.8.1",
+  "version": "1.6.4",
   "description": "Object models for usage with the Bitfinex node API",
   "engines": {
     "node": ">=8.3.0"
@@ -41,7 +41,7 @@
   },
   "homepage": "http://bitfinexcom.github.io/bfx-api-node-models/",
   "devDependencies": {
-    "bfx-api-node-rest": "^5.1.0",
+    "bfx-api-node-rest": "^4.1.2",
     "chai": "^4.2.0",
     "docdash": "^1.2.0",
     "husky": "^4.2.3",

diff --git a/test/lib/models/candle.js b/test/lib/models/candle.js
@@ -27,12 +27,7 @@ describe('Candle model', () => {
 
   it('unserializes live data correctly', async () => {
     const rest = new RESTv2()
-
-    const arr = await rest.candles({
-      timeframe: '1D',
-      symbol: 'tBTCUSD',
-      section: 'hist'
-    })
+    const arr = await rest.candles('tBTCUSD')
 
     arr.forEach(candle => {
       const obj = Candle.unserialize(candle)

diff --git a/test/lib/models/funding_ticker.js b/test/lib/models/funding_ticker.js
@@ -101,7 +101,7 @@ describe('FundingTicker model', () => {
 
   it('unserializes live data correctly', async () => {
     const rest = new RESTv2()
-    const arr = await rest.ticker({ symbol: 'fUSD' })
+    const arr = await rest.ticker('fUSD')
     const obj = FundingTicker.unserialize(arr)
 
     assert.strictEqual(obj.symbol, arr[0])

diff --git a/test/lib/models/funding_ticker_hist.js b/test/lib/models/funding_ticker_hist.js
@@ -74,7 +74,7 @@ describe('FundingTicker history model', () => {
 
   it('unserializes live data correctly', async () => {
     const rest = new RESTv2()
-    const arr = await rest.ticker({ symbol: 'fUSD' })
+    const arr = await rest.ticker('fUSD')
     const obj = FundingTickerHist.unserialize(arr)
 
     assert.strictEqual(obj.symbol, arr[0])

diff --git a/test/lib/models/movement_info.js b/test/lib/models/movement_info.js
diff --git a/test/lib/models/order.js b/test/lib/models/order.js
@@ -512,7 +512,7 @@ describe('Order model', () => {
     it('calls cancelOrder on the interface', (done) => {
       const o = new Order({ id: 42 })
       o.cancel({
-        cancelOrder: async ({ id }) => {
+        cancelOrder: async (id) => {
           assert.strictEqual(id, 42)
           done()
           return []