Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron version up to 25 #251

Merged

Conversation

ZIMkaRU
Copy link
Member

@ZIMkaRU ZIMkaRU commented Sep 15, 2023

This PR bumps electron version up to v25 to have under hood Nodejs v18

We can't update the electron version to the last stable v26, there are some important issues:


Base changes:

  • bumps electron version up to v25
  • bumps nodejs ver up to v18 under docker containers and github actions
  • bumps ubuntu up to v22.04 for github actions
  • change docker-compose config for Compose v2
  • changes min requirements in the Readme
  • fixes always-on-top state for loading window
  • removes deprecated electron.remote module usage
  • uses fs.rm instead of deprecated fs.rmdir for recursive opt

Depends on this PR:

@ZIMkaRU ZIMkaRU marked this pull request as draft September 15, 2023 10:25
@ZIMkaRU ZIMkaRU marked this pull request as ready for review September 19, 2023 09:50
Copy link
Collaborator

@ezewer ezewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ezewer ezewer merged commit 586b055 into bitfinexcom:staging Sep 19, 2023
This was referenced Sep 20, 2023
@ZIMkaRU ZIMkaRU deleted the feature/bump-electron-version-up-to-26 branch March 13, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants