Fixed analyzer.py to display collected flows whose version is not 9 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @irino, thanks for your PR! Happy to see the maintainer of softflowd here 😄 I'd love to merge your PR, but the black formatter did some additional changes I would not merge at the moment. I'm looking into merging your changes without the formatting. |
irino
force-pushed
the
fix_analyzer_for_v1_v5_ipfix
branch
from
c732fba
to
c7c71fa
Compare
|
I reduced unnecessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analyzer.py did not work when decode data collected by collector.py when exporter (softflowd) exported version 1 record, version 5 record or IPFIX record.
This PR fix this problem. This code is formatted by black.