Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/ghost] Remove duplicated empty password check common.validations.values.mysql.passwords #29442

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

LeoColomb
Copy link
Contributor

Description of the change

With the new password management common helper (common.secrets.passwords.manage), custom/dedicated empty password validators are not necessary anymore.

Benefits

Reduce the size and the complexity of the empty password validators, simplifying maintenance.
Also promote indirectly the use of common.secrets.passwords.manage, handling the validation.

Possible drawbacks

Applicable issues

Relates to #29432

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

…tions.values.mysql.passwords`

Signed-off-by: Léo Colombaro <[email protected]>
bitnami-bot and others added 3 commits September 16, 2024 09:46
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 17, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 17, 2024
@github-actions github-actions bot removed the request for review from carrodher September 17, 2024 06:36
Signed-off-by: Bitnami Containers <[email protected]>
@jotamartos jotamartos merged commit d060976 into bitnami:main Sep 19, 2024
9 checks passed
@LeoColomb LeoColomb deleted the fix/ghost-password-validator branch September 19, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghost solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants