Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq] Use common secrets helpers to handle credentials #29561

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

LeoColomb
Copy link
Contributor

Description of the change

Switch to the common helpers common.secrets.passwords.manage & common.secrets.lookup for managing the password instead of the local undocumented helper.

Benefits

  • Streamline with the other charts
  • Use documented helpers
  • Benefit from the common helpers features and maintenance

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added rabbitmq triage Triage is needed labels Sep 22, 2024
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Sep 23, 2024
@github-actions github-actions bot removed the triage Triage is needed label Sep 23, 2024
@github-actions github-actions bot removed the request for review from carrodher September 23, 2024 07:27
bitnami-bot and others added 2 commits September 25, 2024 11:18
Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress rabbitmq verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants