Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/contour]: Fix invalid extraVolumeMounts #29817

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uubk
Copy link

@uubk uubk commented Oct 8, 2024

Description of the change

The default backend's deployment.yaml currently contains the following code:

          {{- if .Values.defaultBackend.extraVolumeMounts }}
          volumeMounts: {{- include "common.tplvalues.render" ( dict "value" .Values.contour.extraVolumeMounts "context" $ ) | nindent 12 }}
          {{- end }}

Note that the if condition uses the correct variable (defaultBackend.extraVolumeMounts) whereas the render call uses the incorrect one (contour.extraVolumeMounts). This looks like a simple copy and paste mistake.

Benefits

The default backends' volumes get rendered correctly.

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

The defaultBackend currently uses the extraVolumeMounts parameters of contour -
make it use its own, like it does in the condition to add the section

Signed-off-by: Maximilian Falkenstein <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Oct 8, 2024
@github-actions github-actions bot removed the triage Triage is needed label Oct 8, 2024
@github-actions github-actions bot removed the request for review from carrodher October 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contour in-progress verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants