Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/external-dns] Add targetLabels option to ServiceMonitor #29828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mrrsm
Copy link

@mrrsm mrrsm commented Oct 8, 2024

Description of the change

Enables the ability to specify podTargetLabels and targetLabels on ServiceMonitor definitions to forward labels on prometheus

Benefits

Increased granularity on metrics

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Bitnami Containers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-dns triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/external-dns] Add targetLabels to the ServiceMonitor for external-dns
3 participants