This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Fix double import breakage #220
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed problem where it would break on double import, causing the program to crash saying there can only be one instance.
Wanted to replace with something more useful, but would require a way to double import bitcore-lib.
|
Okay, this is actually done now as far as I can tell. |
|
@Stilldabomb this will done when you fix |
|
@fanatid this would fix that issue, as the classes grabbed by libraries self-depending on bitcore-lib will be the global bitcore library, which would be whichever one is generated first. I could add some version checking in there to make sure the versions are the same? |
|
Added conflict check so old versions don't silently break.
|
|
@fanatid nothing? |
matiu
reviewed
Nov 29, 2018
| ' not also include their own bitcore-lib dependency.'; | ||
| throw new Error(message); | ||
|
|
||
| if (global._bitcore !== undefind) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed problem where it would break on double import, causing the program to crash saying there can only be one instance.