Skip to content

Commit

Permalink
feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
kajoseph committed Mar 5, 2024
1 parent a149517 commit 46ee91c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 36 deletions.
15 changes: 1 addition & 14 deletions packages/bitcore-lib-doge/test/networks.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,25 +15,12 @@ describe('Networks', function() {
should.exist(networks.defaultNetwork);
});

it('#DEPRECATED will enable/disable regtest Network', function() {
it('should not replace testnet network with regtest', function() {
const beforeEnable = networks.testnet;
networks.enableRegtest();
/*
networks.testnet.networkMagic.should.deep.equal(Buffer.from('fabfb5da', 'hex'));
networks.testnet.port.should.equal(18444);
networks.testnet.dnsSeeds.should.deep.equal([]);
networks.testnet.regtestEnabled.should.equal(true);
*/
networks.testnet.should.deep.equal(beforeEnable);

networks.disableRegtest();
/*
networks.testnet.networkMagic.should.deep.equal(Buffer.from('fcc1b7dc', 'hex'));
networks.testnet.port.should.equal(44556);
networks.testnet.dnsSeeds.should.deep.equal([
'testseed.jrn.me.uk',
]);
*/
networks.testnet.should.deep.equal(beforeEnable);
});

Expand Down
16 changes: 1 addition & 15 deletions packages/bitcore-lib-ltc/test/networks.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,12 @@ describe('Networks', function() {
should.exist(networks.defaultNetwork);
});

it('#DEPRECATED will enable/disable regtest Network', function() {
it('should not replace testnet network with regtest', function() {
const beforeEnable = networks.testnet;
networks.enableRegtest();
/*
networks.testnet.networkMagic.should.deep.equal(Buffer.from('fabfb5da', 'hex'));
networks.testnet.port.should.equal(19444);
networks.testnet.dnsSeeds.should.deep.equal([]);
networks.testnet.regtestEnabled.should.equal(true);
*/
networks.testnet.should.deep.equal(beforeEnable);

networks.disableRegtest();
/*
networks.testnet.networkMagic.should.deep.equal(Buffer.from('fdd2c8f1', 'hex'));
networks.testnet.port.should.equal(19335);
networks.testnet.dnsSeeds.should.deep.equal([
'testnet-seed.litecointools.com',
'seed-b.litecoin.loshan.co.uk'
]);
*/
networks.testnet.should.deep.equal(beforeEnable);
});

Expand Down
8 changes: 1 addition & 7 deletions packages/bitcore-lib/test/networks.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,9 @@ describe('Networks', function() {
should.exist(networks.defaultNetwork);
});

it('#DEPRECATED will enable/disable regtest Network', function() {
it('should not replace testnet network with regtest', function() {
const beforeEnable = networks.testnet;
networks.enableRegtest();
/*
*networks.testnet.networkMagic.should.deep.equal(Buffer.from('fabfb5da', 'hex'));
*networks.testnet.port.should.equal(18444);
*networks.testnet.dnsSeeds.should.deep.equal([]);
*networks.testnet.regtestEnabled.should.equal(true);
*/
networks.testnet.should.deep.equal(beforeEnable);

networks.disableRegtest();
Expand Down

0 comments on commit 46ee91c

Please sign in to comment.