Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Set audience with UMATokenSourceOption upon UMATokenSource instantiation #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndrasHacks
Copy link

@AndrasHacks AndrasHacks commented Dec 18, 2020

In order to enable the UMATokenSource backed HTTPClient development I needed to have a way to create an UMA Token Source, which supports defining audiences, not only at Token Request time, but at Token Source instantiation time as well. This PR enables that.

@sonarcloud
Copy link

sonarcloud bot commented Dec 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tadam313
Copy link
Contributor

tadam313 commented Dec 18, 2020

Let's catch up on this in January, out initial plan was to support audiences via scope mapping which simplifies many things for the clients and also lets us to have well defined scopes to map out other rules for clients based on that. I'd like UMA and OAuth flow to work the same way to avoid confusions at our and the client sides. It's also possible to use scopes with UMA so we can have a standard interface.

Reason behind this:

  • scope: "What I want to do?" -> and we map out the possible audiences for the clients
  • direct audience setting: "Who I want to talk to?" -> need to have different source for every service that I want to talk to -> quite complex on the client side and we don't have any visibility over this in keycloak.

@tadam313 tadam313 changed the title Set audience with UMATokenSourceOption upon UMATokenSource instantiation [WIP] Set audience with UMATokenSourceOption upon UMATokenSource instantiation Dec 18, 2020
@tadam313 tadam313 changed the title [WIP] Set audience with UMATokenSourceOption upon UMATokenSource instantiation WIP: Set audience with UMATokenSourceOption upon UMATokenSource instantiation Dec 18, 2020
@tadam313 tadam313 added the WIP label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants