Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate config files to pyproject.toml #1373

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

SauravMaheshkar
Copy link

@SauravMaheshkar SauravMaheshkar commented Sep 26, 2024

This PR aims to drop the configuration files in favour of pyproject.toml in order to have a more minimal project structure.

Request for Review: @matthewdouglas

Comment on lines +5 to +18
[tool.yapf]
align_closing_bracket_with_visual_indent = true
allow_multiline_lambdas = true
blank_line_before_nested_class_or_def = true
column_limit = 88
coalesce_brackets = true
space_between_ending_comma_and_closing_bracket = true
spaces_before_comment = 2
split_before_bitwise_operator = true
split_before_first_argument = true
split_before_logical_operator = true
split_before_named_assigns = true
split_complex_comprehension = true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project uses ruff-format for formatting (see #1081), so this is unnecessary.

Suggested change
[tool.yapf]
align_closing_bracket_with_visual_indent = true
allow_multiline_lambdas = true
blank_line_before_nested_class_or_def = true
column_limit = 88
coalesce_brackets = true
space_between_ending_comma_and_closing_bracket = true
spaces_before_comment = 2
split_before_bitwise_operator = true
split_before_first_argument = true
split_before_logical_operator = true
split_before_named_assigns = true
split_complex_comprehension = true

split_complex_comprehension = true

[tool.pytest.ini_options]
addopts = "-rP"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the commented-out addopts from the old INI file should be retained for documentation.

pyproject.toml Outdated
Comment on lines 25 to 26
"slow: mark test as slow",
"benchmark: mark test as a benchmark",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could be in alphabetical order, as they were in the INI file.

@matthewdouglas
Copy link
Member

There's an older PR (#1078) that I had started a while ago for the same thing. I'm OK superseding that one with this PR but with some more changes to match the intent of #1078.

The biggest of those changes would be to move more from setup.py to pyproject.toml as was done in #1078.

@SauravMaheshkar
Copy link
Author

There's an older PR (#1078) that I had started a while ago for the same thing. I'm OK superseding that one with this PR but with some more changes to match the intent of #1078.

The biggest of those changes would be to move more from setup.py to pyproject.toml as was done in #1078.

@matthewdouglas I've ported over some of your work from #1078 to this PR. Before I port over changes to the Github Actions changes as well, let's resolve the older comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants