-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate config files to pyproject.toml
#1373
base: main
Are you sure you want to change the base?
chore: migrate config files to pyproject.toml
#1373
Conversation
[tool.yapf] | ||
align_closing_bracket_with_visual_indent = true | ||
allow_multiline_lambdas = true | ||
blank_line_before_nested_class_or_def = true | ||
column_limit = 88 | ||
coalesce_brackets = true | ||
space_between_ending_comma_and_closing_bracket = true | ||
spaces_before_comment = 2 | ||
split_before_bitwise_operator = true | ||
split_before_first_argument = true | ||
split_before_logical_operator = true | ||
split_before_named_assigns = true | ||
split_complex_comprehension = true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This project uses ruff-format
for formatting (see #1081), so this is unnecessary.
[tool.yapf] | |
align_closing_bracket_with_visual_indent = true | |
allow_multiline_lambdas = true | |
blank_line_before_nested_class_or_def = true | |
column_limit = 88 | |
coalesce_brackets = true | |
space_between_ending_comma_and_closing_bracket = true | |
spaces_before_comment = 2 | |
split_before_bitwise_operator = true | |
split_before_first_argument = true | |
split_before_logical_operator = true | |
split_before_named_assigns = true | |
split_complex_comprehension = true |
split_complex_comprehension = true | ||
|
||
[tool.pytest.ini_options] | ||
addopts = "-rP" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the commented-out addopts
from the old INI file should be retained for documentation.
pyproject.toml
Outdated
"slow: mark test as slow", | ||
"benchmark: mark test as a benchmark", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These could be in alphabetical order, as they were in the INI file.
…tes into saurav/configs
Co-authored-by: Matthew Douglas <[email protected]>
@matthewdouglas I've ported over some of your work from #1078 to this PR. Before I port over changes to the Github Actions changes as well, let's resolve the older comments. |
This PR aims to drop the configuration files in favour of
pyproject.toml
in order to have a more minimal project structure.Request for Review: @matthewdouglas