Merge hardfork branch into release branch for 7.0.0 release #2744

abitmore · 2023-05-15T18:45:20Z

Note: don't merge this, but #2751, then this will be marked as merged automatically.

Define and implement the limit_order_update_operation. Still needs testing.

Some major facepalms in here... haha! but overall, it's looking good.

Add logic to match an updated limit order if the price is changed to be higher than the previous top-of-book price. I believe this completes #1604

Add dust check to limit order update logic, and test

Updating an order's expiration must make it expire later than before, not the same or sooner.

I pulled this out of a2192ec because I needed it separated from the rest of that commit.

Guard against the comittee setting fees for the operation which is not yet defined.

Merge develop branch into hardfork branch

Merge release branch back into develop branch

Merge develop branch into hardfork branch

`rewind` is reserved prefix increment `dropped_count, i, next_block_num` for efficiency increment from method call `fetch_by_number()` could cause undefined behavior parenthesis added for explicit operator precedence order of operations clarified max 1 nested break

Fix code smells

Update default values of market history plugin options

Since ES version 8, cannot specify a type when using the Search API or the Count API.

since it tests almost nothing.

Use ElasticSearch 8.5.3 in Github Actions, remove Ubuntu 18

and stop using extra swap file

Settlement code refactory

Implement Order-Sends-Take-Profit-Order feature

By using the block_time field in operation_history_object.

Improve performance of account history wallet APIs by using the block_time field in operation_history_object

Merge develop branch into hardfork branch

Update dependency versions used in Github Actions

Merge develop branch into hardfork branch

Fix a comment in a test case

Fix a test case

Fix a comment in a test case

Fix a test case about updating limit orders

sonarcloud · 2023-07-01T20:10:19Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
16 Code Smells

78.9% Coverage
0.0% Duplication

nathanielhourt and others added 30 commits February 27, 2019 17:17

Progress #1604: Basic implementation

61d85de

Define and implement the limit_order_update_operation. Still needs testing.

Progress #1604: Tests and Fixes

f6bbe4b

Some major facepalms in here... haha! but overall, it's looking good.

Ref #1604: Add matching logic

5484c9f

Add logic to match an updated limit order if the price is changed to be higher than the previous top-of-book price. I believe this completes #1604

Progress #1604: Add dust check

3d24f7c

Add dust check to limit order update logic, and test

Progress #1604: Add hardfork guards

073ecbe

Ref #1604: Another test case

a34c855

Progress #1604: Do not allow sooner expiration

fba5bac

Updating an order's expiration must make it expire later than before, not the same or sooner.

Add fee_schedule::exists<op_type>()

8a82d92

I pulled this out of a2192ec because I needed it separated from the rest of that commit.

Ref #1604: Add missing hardfork guard

6180946

Guard against the comittee setting fees for the operation which is not yet defined.

Eliminate variable fee

55dc688

Update SonarScanner config for hardfork branch

f7b2547

Merge pull request #2563 from bitshares/develop-to-hardfork

5550b40

Merge develop branch into hardfork branch

Update sonar.branch.target for develop branch

b304021

Refactor login_api::login(), fix code smells

456fe19

Merge pull request #2700 from bitshares/merge-release-develop

9d3de7d

Merge release branch back into develop branch

Merge pull request #2701 from bitshares/develop

4b2de74

Merge develop branch into hardfork branch

Update default value of market hist plugin options

9757d82

Update default Docker config about market history

d64b0dc

delinting

95c5a53

`rewind` is reserved prefix increment `dropped_count, i, next_block_num` for efficiency increment from method call `fetch_by_number()` could cause undefined behavior parenthesis added for explicit operator precedence order of operations clarified max 1 nested break

Merge pull request #2705 from bitshares/litepresence-patch-1

d3b18fe

Fix code smells

Merge pull request #2702 from bitshares/update-bucket

bba2e79

Update default values of market history plugin options

Use ES 8.5.3 in Github Actions, remove Ubuntu 18

216da75

Fix ElasticSearch version 8 compatibility

93d70ab

Since ES version 8, cannot specify a type when using the Search API or the Count API.

Check response content when deleting, add logging

eab0b04

Remove the elasticsearch_suite test case

20a3800

since it tests almost nothing.

Add tests for es_plugin::get_operation_by_id()

ec9d712

Add logging about ElasticSearch version detection

3cf8df8

Merge pull request #2707 from bitshares/support-es8

6e0e232

Use ElasticSearch 8.5.3 in Github Actions, remove Ubuntu 18

Limit Java heap size for ES services to 512M in CI

9948390

and stop using extra swap file

Use make -j2 or -j3 in Github Actions workflows

40a13a1

abitmore added 12 commits May 28, 2023 09:49

Update comments

061594f

Merge pull request #2748 from bitshares/settlement-code-refactory

38dbc61

Settlement code refactory

Implement Order-Sends-Take-Profit-Order feature

240a84a

Add tests for take profit order feature

78816b7

Remove unused code

de8339d

Adapt on_fill field (for limit orders) for ES

1afd436

Catch more exceptions when processing on_fill

ad0a5b5

Add tests for failure to send take profit order

ec47739

Merge pull request #2749 from bitshares/pr-2535-oso

9a36b7c

Implement Order-Sends-Take-Profit-Order feature

Improve performance of account history wallet APIs

ed08a9b

By using the block_time field in operation_history_object.

Merge pull request #2644 from bitshares/pr-2643-cli-acc-hist-time

f024d42

Improve performance of account history wallet APIs by using the block_time field in operation_history_object

Merge pull request #2750 from bitshares/develop

e49788d

Merge develop branch into hardfork branch

abitmore marked this pull request as ready for review June 21, 2023 01:48

abitmore mentioned this pull request Jun 21, 2023

Merge hardfork branch into release branch for 7.0.0 release #2751

Merged

abitmore added 13 commits June 21, 2023 17:46

Use ES version 8.8.1 and 7.17.10 in Github Actions

481b67e

Update CURL version used in CI to 8.1.2

a0e1b28

Update OpenSSL version used in CI to 1.1.1u

e4ef0a4

Merge pull request #2752 from bitshares/update-versions-in-ci

a3caf53

Update dependency versions used in Github Actions

Merge pull request #2753 from bitshares/develop

dff65c3

Merge develop branch into hardfork branch

Fix a comment in a test case

b99d62f

Fix a test case

16c7798

Merge pull request #2754 from bitshares/update-comment

7548e6b

Fix a comment in a test case

Merge pull request #2755 from bitshares/fix-tests

c6c7767

Fix a test case

Fix a comment in a test case

2105165

Fix a test case about updating limit orders

29553e3

Merge pull request #2757 from bitshares/update-comment

4d6e7cc

Fix a comment in a test case

Merge pull request #2758 from bitshares/update-tests

3d64cf0

Fix a test case about updating limit orders

abitmore merged commit 3d64cf0 into release Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge hardfork branch into release branch for 7.0.0 release #2744

Merge hardfork branch into release branch for 7.0.0 release #2744

abitmore commented May 15, 2023 •

edited

Loading

sonarcloud bot commented Jul 1, 2023

Merge hardfork branch into release branch for 7.0.0 release #2744

Merge hardfork branch into release branch for 7.0.0 release #2744

Conversation

abitmore commented May 15, 2023 • edited Loading

sonarcloud bot commented Jul 1, 2023

abitmore commented May 15, 2023 •

edited

Loading