Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BRE owner #28

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Make BRE owner #28

merged 1 commit into from
Jan 14, 2025

Conversation

withinfocus
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿ“” Objective

Makes BRE the owner of the repo so that things like updates are caught.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus marked this pull request as ready for review January 13, 2025 22:18
@withinfocus withinfocus requested a review from a team January 13, 2025 22:18
Copy link

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 365117cd-a812-483e-b847-5935a4c9b2d3

Great job, no security vulnerabilities found in this Pull Request

@withinfocus withinfocus merged commit a4c2eab into main Jan 14, 2025
24 checks passed
@withinfocus withinfocus deleted the owner branch January 14, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants