[PM-14526] Add JsonNames annotation to SyncResponseJson #4269
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4269 +/- ##
==========================================
- Coverage 88.98% 88.98% -0.01%
==========================================
Files 452 452
Lines 38946 38945 -1
Branches 5478 5478
==========================================
- Hits 34655 34654 -1
Misses 2369 2369
Partials 1922 1922 ☔ View full report in Codecov by Sentry. |
SaintPatrck
force-pushed
the
cherrypick/hotfix-816b9769-to-main
branch
3 times, most recently
from
f5775f8
to
e3e703e
Compare
SaintPatrck
force-pushed
the
cherrypick/hotfix-816b9769-to-main
branch
from
e3e703e
to
015832e
Compare
david-livefront
approved these changes
Nov 11, 2024
SaintPatrck
commented
Nov 11, 2024
| @@ -125,7 +124,6 @@ class VaultDiskSourceImpl( | |||
| override fun getDomains(userId: String): Flow<SyncResponseJson.Domains?> = | |||
| domainsDao | |||
| .getDomains(userId) | |||
| .filterNotNull() | |||
There was a problem hiding this comment.
📓 Included as part of merge conflicts. Original change should have been in #4268 but was lost during rebase & conflict resolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-14526
Cherry-picked from #4247 (816b976) from branch
release/hotfix-v2024.11.1.📔 Objective
Adds the
@JsonNamesannotation to theprofileanddomainsproperties in theSyncResponseJsondata class.This ensures that the properties are correctly deserialized even if the server response uses different casing for the property names.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes