Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-14333 Complete fix for crash caused by spannable text creation #4479

Merged
merged 5 commits into from
Dec 20, 2024
+384 −545

update new annotated string to use this method

4c9423f
Select commit
Loading
Failed to load commit list.
Merged

PM-14333 Complete fix for crash caused by spannable text creation #4479

update new annotated string to use this method
4c9423f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 20, 2024 in 0s

88.89% (-0.05%) compared to f32eecc, passed because coverage increased by 0% when compared to adjusted base (88.89%)

View this Pull Request on Codecov

88.89% (-0.05%) compared to f32eecc, passed because coverage increased by 0% when compared to adjusted base (88.89%)

Details

Codecov Report

Attention: Patch coverage is 89.90826% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (f32eecc) to head (4c9423f).

Files with missing lines Patch % Lines
...arden/ui/platform/base/util/StringResExtensions.kt 91.66% 0 Missing and 5 partials ⚠️
...ature/startregistration/StartRegistrationScreen.kt 50.00% 4 Missing ⚠️
...rtlogins/components/ImportLoginsInstructionStep.kt 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
- Coverage   88.93%   88.89%   -0.05%     
==========================================
  Files         459      460       +1     
  Lines       39839    39754      -85     
  Branches     5634     5643       +9     
==========================================
- Hits        35432    35340      -92     
- Misses       2440     2443       +3     
- Partials     1967     1971       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov