-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15906] Implement single tap passkey flows #4547
Open
SaintPatrck
wants to merge
1
commit into
main
Choose a base branch
from
PM-15906/single-tap-passkey-flows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+287
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaintPatrck
requested review from
brian-livefront,
david-livefront,
dseverns-livefront,
ahaisting-livefront,
phil-livefront and
a team
as code owners
January 10, 2025 15:16
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 10, 2025 15:17
4558b28
to
4680813
Compare
Great job, no security vulnerabilities found in this Pull Request |
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 10, 2025 16:01
4680813
to
0a9effb
Compare
This comment was marked as resolved.
This comment was marked as resolved.
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 10, 2025 17:47
0a9effb
to
4090cfc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4547 +/- ##
==========================================
- Coverage 88.31% 88.27% -0.04%
==========================================
Files 603 603
Lines 40272 40318 +46
Branches 5697 5712 +15
==========================================
+ Hits 35565 35592 +27
- Misses 2721 2731 +10
- Partials 1986 1995 +9 ☔ View full report in Codecov by Sentry. |
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 10, 2025 18:12
4090cfc
to
518e8df
Compare
...rc/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorImpl.kt
Outdated
Show resolved
Hide resolved
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 13, 2025 18:05
518e8df
to
9f77e44
Compare
This change adds a biometric prompt to the passkey autofill flow. The biometric prompt will be shown when creating or authenticating with a passkey if the user has supported device biometrics enabled. This change also adds an isUserVerified flag to the Fido2 requests to determine if the user has verified their identity using the single tap flow.
SaintPatrck
force-pushed
the
PM-15906/single-tap-passkey-flows
branch
from
January 13, 2025 18:58
9f77e44
to
815e03b
Compare
david-livefront
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-15906
PM-12511
Resolves #3953
📔 Objective
Add a biometric prompt to the passkey registration and authentication flows.
The biometric prompt will be shown when creating or authenticating with a passkey if the user has supported device biometrics enabled.
This change also adds an
isUserVerified
flag to the Fido2 requests to determine if the user has verified their identity using the single tap flow.Note
When vault timeout is set to immediate, users must unlock multiple times. This is intentional since the application is set to lock immediately after backgrounding and the passkey flow requires backgrounding the application after initial unlock and credential discovery.
📸 Screenshots
Device biometrics enabled
Vault timeout not
immediate
multi-tap-creation.webm
single-tap-creation-biometrics.webm
multi-tap-authentication.webm
single-tap-auth-biometrics.webm
Vault timeout set to
immediate
single-tap-creation-immediate-timeout.webm
single-tap-auth-immediate-timeout.webm
Device biometrics disabled
Vault timeout not
immediate
single-tap-creation-pin.webm
single-tap-auth-pin.webm
Vault timeout set to
immediate
single-tap-creation-pin-immediate-timeout.webm
single-tap-auth-pin-immediate-timeout.webm
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes