[DRAFT] PM-16631 - CoachMark tour of adding log in item. #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
| ) { | ||
| private val mutex = Mutex() | ||
| private val highlights: MutableMap<T, CoachMarkHighlightState<T>?> = mutableMapOf() | ||
| private val _currentHighlight = mutableStateOf(initialCoachMarkHighlight) |
There was a problem hiding this comment.
The underscores is not really a pattern in the app, can we call this mutableCurrentHighlight. Same for all the others
| toolTipState: TooltipState, | ||
| shape: CoachMarkHighlightShape = CoachMarkHighlightShape.SQUARE, | ||
| ) { | ||
| mutex.withLock { |
There was a problem hiding this comment.
I thought we got rid of this mutex?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-16631
📔 Objective
VaultAddEditContentcontent.📸 Screenshots
What works nicely:
Static content:
progress.webm
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes