BIT-589 Prevent crash on Landing when navigating with empty input (#59)

bitwarden · Jun 20, 2024 · 3548340 · 3548340
1 parent 3de916c
commit 3548340
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt
@@ -49,6 +49,10 @@ class LandingViewModel @Inject constructor(
     }
 
     private fun handleContinueButtonClicked() {
+        // TODO: add actual validation here: BIT-193
+        if (mutableStateFlow.value.emailInput.isBlank()) {
+            return
+        }
         sendEvent(LandingEvent.NavigateToLogin(mutableStateFlow.value.emailInput))
     }
 

diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt b/app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt
@@ -34,15 +34,24 @@ class LandingViewModelTest : BaseViewModelTest() {
     @Test
     fun `ContinueButtonClick should emit NavigateToLogin`() = runTest {
         val viewModel = LandingViewModel(SavedStateHandle())
+        viewModel.trySendAction(LandingAction.EmailInputChanged("input"))
         viewModel.eventFlow.test {
             viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
             assertEquals(
-                LandingEvent.NavigateToLogin(""),
+                LandingEvent.NavigateToLogin("input"),
                 awaitItem(),
             )
         }
     }
 
+    @Test
+    fun `ContinueButtonClick with empty input should do nothing`() = runTest {
+        val viewModel = LandingViewModel(SavedStateHandle())
+        viewModel.eventFlow.test {
+            viewModel.actionChannel.trySend(LandingAction.ContinueButtonClick)
+        }
+    }
+
     @Test
     fun `CreateAccountClick should emit NavigateToCreateAccount`() = runTest {
         val viewModel = LandingViewModel(SavedStateHandle())