Fix initial detekt issues (#10)

bitwarden · Jun 20, 2024 · ee199b9 · ee199b9
1 parent dc2ed44
commit ee199b9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt b/app/src/main/java/com/x8bit/bitwarden/ui/components/PlaceholderComposable.kt
@@ -14,7 +14,7 @@ import androidx.compose.ui.graphics.Color
  */
 @Composable
 fun PlaceholderComposable(
-    text: String = "Placeholder Composable"
+    text: String = "Placeholder Composable",
 ) {
     Box(
         modifier = Modifier

diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavScreen.kt
@@ -18,7 +18,7 @@ import com.x8bit.bitwarden.ui.components.PlaceholderComposable
  */
 @Composable
 fun RootNavScreen(
-    viewModel: RootNavViewModel = viewModel()
+    viewModel: RootNavViewModel = viewModel(),
 ) {
     val navController = rememberNavController()
     val state by viewModel.state.collectAsStateWithLifecycle()
@@ -49,6 +49,7 @@ fun RootNavScreen(
 /**
  * TODO: move to splash package (BIT-147)
  */
+@Suppress("TopLevelPropertyNaming")
 private const val SplashRoute = "splash"
 
 /**
@@ -81,7 +82,8 @@ private fun NavController.navigateToSplashAsRoot() {
 /**
  * TODO move to login package(BIT-146)
  */
-private val LoginRoute = "login"
+@Suppress("TopLevelPropertyNaming")
+private const val LoginRoute = "login"
 
 /**
  * Add login destinations to the nav graph.

diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/feature/rootnav/RootNavViewModel.kt
@@ -21,11 +21,11 @@ class RootNavViewModel @Inject constructor() : ViewModel() {
 
     init {
         viewModelScope.launch {
+            @Suppress("MagicNumber")
             delay(1000)
             _state.value = RootNavState.Login
         }
     }
-
 }
 
 /**