Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bitwarden import #120

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Fix Bitwarden import #120

merged 2 commits into from
Jun 12, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Jun 12, 2024

🎟️ Tracking

Internal change

📔 Objective

Notify users when importing a Bitwarden file fails.

Modify Bitwarden parser to be more lenient when evaluating OTP keys.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner June 12, 2024 15:25
Copy link
Contributor

github-actions bot commented Jun 12, 2024

Logo
Checkmarx One – Scan Summary & Detailsaf7e3879-db84-43f7-8ccc-138f80af4f20

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 0.88%. Comparing base (9912123) to head (70fa9a5).

Files Patch % Lines
...m/manager/imports/parsers/BitwardenExportParser.kt 0.00% 12 Missing ⚠️
...nticator/repository/AuthenticatorRepositoryImpl.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #120      +/-   ##
========================================
+ Coverage   0.87%   0.88%   +0.01%     
========================================
  Files         84      84              
  Lines       4344    4293      -51     
  Branches     700     688      -12     
========================================
  Hits          38      38              
+ Misses      4302    4251      -51     
  Partials       4       4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck merged commit 18e5b71 into main Jun 12, 2024
8 checks passed
@SaintPatrck SaintPatrck deleted the fix/bitwarden-import-failure branch June 12, 2024 15:46
ahaisting-livefront pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants