Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language switcher #121

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Jun 12, 2024

🎟️ Tracking

Internal change.

📔 Objective

Remove the language selector from Settings since we do not currently have translations for other languages.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner June 12, 2024 15:30
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details51c66d37-18e0-4bc4-9476-0b9051da177c

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.87%. Comparing base (e737f32) to head (83306f4).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #121   +/-   ##
=====================================
  Coverage   0.86%   0.87%           
=====================================
  Files         84      84           
  Lines       4380    4344   -36     
  Branches     706     700    -6     
=====================================
  Hits          38      38           
+ Misses      4338    4302   -36     
  Partials       4       4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck merged commit 9912123 into main Jun 12, 2024
8 checks passed
@SaintPatrck SaintPatrck deleted the settings/remove-language-switcher branch June 12, 2024 15:38
ahaisting-livefront pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants