Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape and use correct apostrophe symbol #130

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Escape and use correct apostrophe symbol #130

merged 1 commit into from
Jun 17, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Jun 17, 2024

🎟️ Tracking

Internal change

📔 Objective

Replace character with apostrophe symbol and correctly escape apostrophes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner June 17, 2024 16:10
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7d0747ea-9d28-4bee-bd65-e88bcf1c40ce

No New Or Fixed Issues Found

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.94%. Comparing base (49a5ff3) to head (5229890).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #130   +/-   ##
=====================================
  Coverage   0.94%   0.94%           
=====================================
  Files         85      85           
  Lines       4348    4348           
  Branches     625     625           
=====================================
  Hits          41      41           
  Misses      4246    4246           
  Partials      61      61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SaintPatrck SaintPatrck merged commit 8be57a6 into main Jun 17, 2024
8 checks passed
@SaintPatrck SaintPatrck deleted the typo-fix branch June 17, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants