Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to search items #23

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 11, 2024

🎟️ Tracking

N/A

📔 Objective

Add a search button to the Item Listing screen that allows users to search through saved items.

📸 Screenshots

Screen Dark Light
Search - Empty image image
Search - No Results image image
Search - Results image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

TODO: Include TOTP details (e.g. remaining time, alert threshold, verification code, copy button)
…ction-button

# Conflicts:
#	app/src/main/res/values/strings.xml
…ction-button

# Conflicts:
#	app/src/main/kotlin/com/x8bit/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt
Copy link
Contributor

github-actions bot commented Apr 11, 2024

Logo
Checkmarx One – Scan Summary & Details12f49603-80ef-47d0-baa0-c40d51d0b4be

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck marked this pull request as ready for review April 11, 2024 23:14
@SaintPatrck SaintPatrck requested a review from a team as a code owner April 11, 2024 23:14
@SaintPatrck SaintPatrck enabled auto-merge (squash) April 11, 2024 23:17
@SaintPatrck SaintPatrck merged commit a27002a into main Apr 12, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the item-listing-search-action-button branch April 12, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants