Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIsplay base settings screen #25

Merged
merged 5 commits into from
Apr 14, 2024
Merged

DIsplay base settings screen #25

merged 5 commits into from
Apr 14, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 13, 2024

🎟️ Tracking

N/A

📔 Objective

Allow users to navigate to the Settings screen.

📸 Screenshots

Screen Dark Mode Light Mode
Settings image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

…-ui-root

# Conflicts:
#	app/src/main/kotlin/com/x8bit/bitwarden/authenticator/ui/platform/base/util/ModifierExtensions.kt
Copy link
Contributor

github-actions bot commented Apr 13, 2024

Logo
Checkmarx One – Scan Summary & Detailsa08140bc-be15-4db1-9062-5fbd6b61f649

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck marked this pull request as ready for review April 13, 2024 23:03
@SaintPatrck SaintPatrck requested a review from a team as a code owner April 13, 2024 23:03
@SaintPatrck SaintPatrck merged commit 6b02583 into main Apr 14, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the settings-ui-root branch April 14, 2024 00:39
ahaisting-livefront pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants