Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy auth code on item click #28

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Copy auth code on item click #28

merged 3 commits into from
Apr 16, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

When clicked, copy the item's auth code to device clipboard.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 14, 2024 22:32
Copy link
Contributor

github-actions bot commented Apr 14, 2024

Logo
Checkmarx One – Scan Summary & Detailsf576bdeb-05cf-423d-b061-dff0669790fc

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck changed the title clipboard-manager Copy auth code on item click Apr 15, 2024
# Conflicts:
#	app/src/main/res/values/strings.xml
@SaintPatrck SaintPatrck merged commit 8da98f9 into main Apr 16, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the clipboard-manager branch April 16, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants