Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mobile dev team as default code owners #3

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

SaintPatrck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

Mobile dev team are default code owners for authenticator app code.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner March 27, 2024 02:18
@SaintPatrck SaintPatrck enabled auto-merge (squash) March 27, 2024 03:20
@SaintPatrck SaintPatrck merged commit 8553fb3 into main Mar 27, 2024
4 of 5 checks passed
@SaintPatrck SaintPatrck deleted the update-codeowners branch March 27, 2024 09:31
@vvolkgang
Copy link
Member

@SaintPatrck @KatherineInCode Given that you will be reviewing each other's PRs, I would suggest commenting this for the time being as it will spam everyone in that team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants