Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x8bit references from project #37

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Remove x8bit references from project #37

merged 2 commits into from
Apr 17, 2024

Conversation

SaintPatrck
Copy link
Contributor

🎟️ Tracking

N/A

📔 Objective

Change package ID to com.bitwarden.authenticator.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Logo
Checkmarx One – Scan Summary & Details270a577d-71b2-4f5a-a792-6c175728c70e

No New Or Fixed Issues Found

# Conflicts:
#	app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt
#	app/src/main/res/xml/backup_rules.xml
@SaintPatrck SaintPatrck marked this pull request as ready for review April 17, 2024 03:48
@SaintPatrck SaintPatrck requested a review from a team as a code owner April 17, 2024 03:48
@SaintPatrck SaintPatrck merged commit af1ab4c into main Apr 17, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the package-id-change branch April 17, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants