Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble, sign, upload and publish release builds #38

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 18, 2024

🎟️ Tracking

N/A

📔 Objective

Build signed release APK's for uploading and publishing.

Version code and name are derived based on the latest version information from Firebase. Version codes are incremented on each publication. Version name is derived from the current year, date, and latest published release's revision number.

Prod variants are published to Firebase from master branch. Firebase publication uses the last commit message as the release notes.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Apr 18, 2024

Logo
Checkmarx One – Scan Summary & Details5474762c-27eb-4e1d-8a3c-3b4e7d2fcaa2

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck force-pushed the github-workflow-assemble-release branch from e914326 to 7a7988f Compare April 20, 2024 04:16
@SaintPatrck SaintPatrck marked this pull request as ready for review April 20, 2024 04:27
@SaintPatrck SaintPatrck requested review from a team as code owners April 20, 2024 04:27
@SaintPatrck SaintPatrck force-pushed the github-workflow-assemble-release branch from 7a7988f to ae46a78 Compare April 20, 2024 04:28
@SaintPatrck SaintPatrck enabled auto-merge (squash) April 20, 2024 18:25
@SaintPatrck SaintPatrck force-pushed the github-workflow-assemble-release branch 3 times, most recently from d3e5a5a to b3063fe Compare April 22, 2024 12:55
@SaintPatrck SaintPatrck disabled auto-merge April 22, 2024 14:28
@SaintPatrck SaintPatrck force-pushed the github-workflow-assemble-release branch from b3063fe to 9951bad Compare April 22, 2024 14:39
# Conflicts:
#	app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt
Copy link

@mimartin12 mimartin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some linting changes.

I did notice that there are some uses of shell: bash, but the runner is Ubuntu, which already defaults to Bash. Up to you if you want to remove it though.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@SaintPatrck
Copy link
Contributor Author

Thanks, @mimartin12!
Your linting suggestions have been applied.
I'd prefer to keep the explicit shell:bash declarations if it doesn't negatively impact anything.

@SaintPatrck SaintPatrck requested a review from mimartin12 April 22, 2024 16:53
Copy link

@mimartin12 mimartin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with me!

@SaintPatrck SaintPatrck merged commit e829e1e into main Apr 22, 2024
4 checks passed
@SaintPatrck SaintPatrck deleted the github-workflow-assemble-release branch April 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants