-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assemble, sign, upload and publish release builds #38
Conversation
No New Or Fixed Issues Found |
e914326
to
7a7988f
Compare
7a7988f
to
ae46a78
Compare
d3e5a5a
to
b3063fe
Compare
b3063fe
to
9951bad
Compare
# Conflicts: # app/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some linting changes.
I did notice that there are some uses of shell: bash
, but the runner is Ubuntu, which already defaults to Bash. Up to you if you want to remove it though.
Co-authored-by: MtnBurrit0 <[email protected]>
Thanks, @mimartin12! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works with me!
🎟️ Tracking
N/A
📔 Objective
Build signed release APK's for uploading and publishing.
Version code and name are derived based on the latest version information from Firebase. Version codes are incremented on each publication. Version name is derived from the current year, date, and latest published release's revision number.
Prod variants are published to Firebase from
master
branch. Firebase publication uses the last commit message as the release notes.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes