Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Import button from empty item listing screen #40

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 20, 2024

🎟️ Tracking

N/A

📔 Objective

Remove import button from empty listing screen.

📸 Screenshots

Screen Dark Theme Light Theme
Item Listing - Empty image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 20, 2024 21:48
Copy link
Contributor

github-actions bot commented Apr 20, 2024

Logo
Checkmarx One – Scan Summary & Detailsa595611b-a7f4-4fe3-bc4a-05d58ce5f7b4

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck merged commit 066d5c5 into main Apr 22, 2024
5 checks passed
@SaintPatrck SaintPatrck deleted the remove-import-items-button branch April 22, 2024 14:29
ahaisting-livefront added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants