Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display correct icons when app overrides system theme #56

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 25, 2024

🎟️ Tracking

N/A

📔 Objective

Display the correct image variant when overriding system default theme.

📸 Screenshots

Header Header
AppTheme - Light image
AppTheme - Dark image
AppTheme - Default (Dark System Theme) image
AppTheme - Default (Light System Theme) image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 25, 2024 21:18
Copy link
Contributor

github-actions bot commented Apr 25, 2024

Logo
Checkmarx One – Scan Summary & Details9f6487d7-a90e-44ac-b947-c5070ee02d97

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck enabled auto-merge (squash) April 25, 2024 21:25
@SaintPatrck SaintPatrck changed the title Display correct icons when app overrides system theme. Display correct icons when app overrides system theme Apr 25, 2024
@SaintPatrck SaintPatrck merged commit f39669e into main Apr 25, 2024
6 checks passed
@SaintPatrck SaintPatrck deleted the fix/dark-theme-override-handling branch April 25, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants