Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release prep and refinement #64

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Release prep and refinement #64

merged 2 commits into from
Apr 27, 2024

Conversation

SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Apr 27, 2024

🎟️ Tracking

N/A

📔 Objective

Change app name to "Authenticator".

Update app logo and launcher icons.

Update verbiage in various locations.

Perform input validation on manual entry screen.

📸 Screenshots

Description Dark Light
Launcher Icon image image
Launcher Icon Themed (Green) image image
Splash image image
Unlock image image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@SaintPatrck SaintPatrck requested a review from a team as a code owner April 27, 2024 17:18
Copy link
Contributor

github-actions bot commented Apr 27, 2024

Logo
Checkmarx One – Scan Summary & Details96e0f324-e1db-4745-a2a9-c05e71d6fae4

No New Or Fixed Issues Found

@SaintPatrck SaintPatrck enabled auto-merge (squash) April 27, 2024 18:03
@SaintPatrck SaintPatrck disabled auto-merge April 27, 2024 18:25
@SaintPatrck SaintPatrck changed the title Update app name and launcher icon Pre-release refinement Apr 27, 2024
@SaintPatrck SaintPatrck changed the title Pre-release refinement Release prep and refinement Apr 27, 2024
@SaintPatrck SaintPatrck merged commit c0b0469 into main Apr 27, 2024
6 checks passed
@SaintPatrck SaintPatrck deleted the update-logo-and-app-name branch April 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants