[BWA-55] Add Long Press Menu to Search (#194)

bitwarden · Nov 21, 2024 · d0a2899 · d0a2899
1 parent 309d296
commit d0a2899
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 10 deletions.
diff --git a/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessor.swift b/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListProcessor.swift
@@ -151,6 +151,9 @@ final class ItemListProcessor: StateProcessor<ItemListState, ItemListAction, Ite
     private func deleteItem(_ id: String) async {
         do {
             try await services.authenticatorItemRepository.deleteAuthenticatorItem(id)
+            if !state.searchText.isEmpty {
+                state.searchResults = await searchItems(for: state.searchText)
+            }
             state.toast = Toast(text: Localizations.itemDeleted)
         } catch {
             services.errorReporter.log(error: error)
@@ -323,6 +326,9 @@ final class ItemListProcessor: StateProcessor<ItemListState, ItemListAction, Ite
                 if showToast {
                     state.toast = Toast(text: Localizations.accountsSyncedFromBitwardenApp)
                 }
+                if !state.searchText.isEmpty {
+                    state.searchResults = await searchItems(for: state.searchText)
+                }
             }
         } catch {
             services.errorReporter.log(error: error)

diff --git a/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift b/AuthenticatorShared/UI/Vault/ItemList/ItemList/ItemListView.swift
@@ -199,16 +199,8 @@ private struct SearchableItemListView: View {
             ScrollView {
                 LazyVStack(spacing: 0) {
                     ForEach(store.state.searchResults) { item in
-                        Button {
-                            store.send(.itemPressed(item))
-                        } label: {
-                            itemListItemRow(
-                                for: item,
-                                isLastInSection: store.state.searchResults.last == item
-                            )
-                            .background(Asset.Colors.backgroundPrimary.swiftUIColor)
-                        }
-                        .accessibilityIdentifier("ItemCell")
+                        buildRow(item: item, isLastInSection: store.state.searchResults.last == item)
+                            .accessibilityIdentifier("ItemCell")
                     }
                 }
             }

diff --git a/...ListViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portrait.png b/...ListViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portrait.png
diff --git a/...ViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitDark.png b/...ViewTests/test_snapshot_ItemListView_previews.3-Search-Results-portraitDark.png
diff --git a/...__/ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portrait.png b/...__/ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portrait.png
diff --git a/...ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitAX5.png b/...ItemListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitAX5.png
diff --git a/...temListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitDark.png b/...temListViewTests/test_snapshot_ItemListView_previews.SyncError-portraitDark.png