Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist authenticator items to a database #18

Merged
merged 24 commits into from
Apr 10, 2024
Merged

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This moves to AuthenticatorItem as the primary thing owned by the application—analogous to Cipher in the main app—and builds the persistence layer for creating/updating/deleting items from the internal store. Create and update are wired up to the views; delete will come in another PR because it requires moving around some UI things. An edit does not currently update the View Item screen; this will be fixed when the flow gets updated to match the current intended UI. A number of references to Token are still scattered in the code and comments, most of which should get zapped with the UI update coming soon-ish.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner April 9, 2024 03:18
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Logo
Checkmarx One – Scan Summary & Detailsf25d3d2a-965a-4438-b387-2d55e7775ecb

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit b99af3c into main Apr 10, 2024
5 checks passed
@KatherineInCode KatherineInCode deleted the persist-items branch April 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants