Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial project structure #2

Merged
merged 9 commits into from
Mar 28, 2024
Merged

Initial project structure #2

merged 9 commits into from
Mar 28, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This creates a basic framework of an application project, based on the iOS app's current structure

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner March 21, 2024 22:36
@KatherineInCode KatherineInCode requested a review from a team as a code owner March 22, 2024 11:23
@djsmith85 djsmith85 removed the request for review from a team March 22, 2024 11:23
@withinfocus withinfocus reopened this Mar 26, 2024
AuthenticatorShared/Application/Support/Info.plist Outdated Show resolved Hide resolved
project.yml Outdated Show resolved Hide resolved
Authenticator/Application/Support/GoogleService-Info.plist Outdated Show resolved Hide resolved
Authenticator/Application/Support/GoogleService-Info.plist Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Mar 28, 2024

Logo
Checkmarx One – Scan Summary & Details0ac5cfd8-eac9-41db-b236-ebbd5a7321c0

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit bda51fc into main Mar 28, 2024
5 checks passed
@KatherineInCode KatherineInCode deleted the initial-setup branch March 28, 2024 19:42
victor-livefront pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants