Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OTP Auth Model to closer match spec #21

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This updates the OTPAuthModel object—which represents a token parsed from an otpauth protocol—to include issuer and account, along with updating terms (notably, key -> secret) and being able to reproduce itself in URI form. This is all to more closely match the Google Spec.

This lays groundwork for editing authenticator items.

We do not currently support the hotp type.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner April 11, 2024 02:50
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details8b6123ce-9cab-4c64-badf-14ac351c9c1c

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit 7c0b9a4 into main Apr 11, 2024
5 checks passed
@KatherineInCode KatherineInCode deleted the update-otp-key-model branch April 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants