[BWA-82] Don't Timeout When User Selects Never #212
Conversation
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #212 +/- ##
==========================================
- Coverage 70.16% 70.11% -0.06%
==========================================
Files 215 215
Lines 9865 9873 +8
==========================================
Hits 6922 6922
- Misses 2943 2951 +8 ☔ View full report in Codecov by Sentry. |
| @@ -63,8 +63,12 @@ class AppCoordinator: Coordinator, HasRootNavigator { | |||
| func handleEvent(_ event: AppEvent, context: AnyObject?) async { | |||
| switch event { | |||
| case .didStart: | |||
| let accountId = await services.stateService.getActiveAccountId() | |||
| let hasTimeout = services.appSettingsStore.vaultTimeout(userId: accountId) != | |||
There was a problem hiding this comment.
🤔 Could we get this setting from the state service as well? In PM, at least, we have convenience methods there that avoid needing to also get the account ID.
There was a problem hiding this comment.
Yeah that makes sense. It is awkward to have to do both.
There was a problem hiding this comment.
Should be cleaned up a bit in the latest commit. 👍
…of having to call 2 different services
brant-livefront
deleted the
brant/BWA-82-dont-timeout-when-user-selects-never
branch
🎟️ Tracking
BWA-82
📔 Objective
This PR fixes an issue where a user who has biometric authentication turned on, but selects "Never" as their timeout duration would still be prompted for biometrics when the app was closed and re-opened. This PR adds an additional check on startup to allow the user to bypass biometric authentication if they have selected "Never".
📸 Screenshots
NeverLock.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes