Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build edit item screen #23

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Build edit item screen #23

merged 2 commits into from
Apr 12, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This fleshes out the edit item screen, and makes it work with saving things back into the database.

Instead of putting Advanced options on another screen, it does use a collapsing/expanding system like the vault app handles options on creating a new send.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-04-12 at 12 31 22

Simulator Screenshot - iPhone 15 Pro - 2024-04-12 at 12 31 27

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner April 12, 2024 20:17
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1d9e44bd-5351-4eea-aa1d-b0960b1b92c7

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit 4f6f2e8 into main Apr 12, 2024
4 checks passed
@KatherineInCode KatherineInCode deleted the edit-item branch April 12, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants