Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration service #28

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Add migration service #28

merged 1 commit into from
Apr 13, 2024

Conversation

KatherineInCode
Copy link
Contributor

๐Ÿ“” Objective

This brings in a migration service to be used for data migrations in the future, and fixes up a lot of tests along the way

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner April 13, 2024 20:58
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 31b168a5-2ba9-4323-8687-741fc05d0951

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit 3095dd6 into main Apr 13, 2024
4 checks passed
@KatherineInCode KatherineInCode deleted the fix-tests branch April 13, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants