Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service name field to the manual TOTP add screen #33

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This adds a Service field to the manual Add TOTP screen, which is mandatory, and is used to name the item when it's added to the list. As well, items added via QR code use the issuer (if available) or account name (if available) for an initial name of an item.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-04-13 at 17 22 56

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team as a code owner April 13, 2024 22:24
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsde5f608e-c107-413b-8655-2f39c64df101

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit cdd6a3f into main Apr 13, 2024
4 checks passed
@KatherineInCode KatherineInCode deleted the name-in-add branch April 13, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants