Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scan Workflow Permission #4

Closed
wants to merge 2 commits into from
Closed

Conversation

Eeebru
Copy link
Contributor

@Eeebru Eeebru commented Mar 26, 2024

🎟️ Tracking

📔 Objective

  • Update Scan Workflow Permission

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Eeebru Eeebru requested a review from a team as a code owner March 26, 2024 20:23
@Eeebru Eeebru enabled auto-merge (squash) March 26, 2024 21:34
@Eeebru Eeebru self-assigned this Mar 26, 2024
@@ -10,7 +10,9 @@ on:
pull_request_target:
types: [opened, synchronize]

permissions: read-all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave the permissions set to read-all here and update the permissions block on line 24 with:

permissions:
  contents: read
  security-events: write

Line 13 sets all scoped permissions to read , something like {actions: read, contents: read, issues: read, security-events: read, ...etc}. Line 24 then overrides all workflow level permissions to {security-events: write, actions: none, contents: none, ....etc}. Line 24 needs to be updated to explicitly include all other required scopes the job needs since they will be set to none if not explicitly set, even though the workflow permissions are set to read-all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been updated @joseph-flinn

@withinfocus
Copy link
Contributor

Applied an alternative solution manually.

auto-merge was automatically disabled March 27, 2024 14:14

Pull request was closed

@withinfocus withinfocus deleted the update-scan-permission branch March 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants