Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SM-1302] Initial config page #10196

Merged
merged 26 commits into from
Sep 20, 2024
Merged

[SM-1302] Initial config page #10196

merged 26 commits into from
Sep 20, 2024

Conversation

differsthecat
Copy link
Member

@differsthecat differsthecat commented Jul 19, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1302

📔 Objective

Add a config page to machine accounts to give users easier access to necessary variables for using bws and the language wrappers.

📸 Screenshots

Demo of the config page:

Screen.Recording.2024-07-22.at.9.32.38.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Logo
Checkmarx One – Scan Summary & Details96cdb3c8-f3b0-4713-a0f0-ef4766a14592

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 51 Attack Vector

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.

Project coverage is 34.98%. Comparing base (ea025b9) to head (f05e632).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...anager/service-accounts/config/config.component.ts 0.00% 48 Missing ⚠️
.../secrets-manager/shared/projects-list.component.ts 0.00% 4 Missing ⚠️
...rc/app/secrets-manager/projects/project.service.ts 0.00% 1 Missing ⚠️
...ervice-accounts/service-accounts-routing.module.ts 0.00% 1 Missing ⚠️
...anager/service-accounts/service-accounts.module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10196      +/-   ##
==========================================
- Coverage   34.99%   34.98%   -0.02%     
==========================================
  Files        2711     2712       +1     
  Lines       84521    84576      +55     
  Branches    16063    16069       +6     
==========================================
+ Hits        29579    29585       +6     
- Misses      53971    54020      +49     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@differsthecat differsthecat marked this pull request as ready for review July 22, 2024 14:06
@differsthecat differsthecat requested a review from a team as a code owner July 22, 2024 14:06
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying from project list component can be simplified.
The copy component likely have a race condition and the services that pull the data should be part of RXJS pipe.

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looking forward to this one.

Thomas-Avery
Thomas-Avery previously approved these changes Jul 29, 2024
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, few promise simplifications

…unts/config/config.component.ts

Co-authored-by: Maciej Zieniuk <[email protected]>
mzieniukbw
mzieniukbw previously approved these changes Jul 30, 2024
mzieniukbw
mzieniukbw previously approved these changes Jul 30, 2024
Copy link
Contributor

@mzieniukbw mzieniukbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small simplification request

mzieniukbw
mzieniukbw previously approved these changes Sep 20, 2024
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@differsthecat differsthecat merged commit cf1f7cc into main Sep 20, 2024
35 checks passed
@differsthecat differsthecat deleted the sm-1302-config-page branch September 20, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants