-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SM-1302] Initial config page #10196
Conversation
New Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10196 +/- ##
==========================================
- Coverage 34.99% 34.98% -0.02%
==========================================
Files 2711 2712 +1
Lines 84521 84576 +55
Branches 16063 16069 +6
==========================================
+ Hits 29579 29585 +6
- Misses 53971 54020 +49
Partials 971 971 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying from project list component can be simplified.
The copy component likely have a race condition and the services that pull the data should be part of RXJS pipe.
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/shared/projects-list.component.html
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/shared/projects-list.component.ts
Outdated
Show resolved
Hide resolved
…unts/config/config.component.ts Co-authored-by: Maciej Zieniuk <[email protected]>
…cts-list.component.ts Co-authored-by: Maciej Zieniuk <[email protected]>
Co-authored-by: Maciej Zieniuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Looking forward to this one.
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.html
Show resolved
Hide resolved
...rden_license/bit-web/src/app/secrets-manager/service-accounts/service-account.component.html
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/shared/projects-list.component.ts
Outdated
Show resolved
Hide resolved
…unts/config/config.component.ts Co-authored-by: Thomas Avery <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, few promise simplifications
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
…unts/config/config.component.ts Co-authored-by: Maciej Zieniuk <[email protected]>
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small simplification request
bitwarden_license/bit-web/src/app/secrets-manager/service-accounts/config/config.component.ts
Outdated
Show resolved
Hide resolved
…unts/config/config.component.ts Co-authored-by: Maciej Zieniuk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
🎟️ Tracking
https://bitwarden.atlassian.net/browse/SM-1302
📔 Objective
Add a config page to machine accounts to give users easier access to necessary variables for using
bws
and the language wrappers.📸 Screenshots
Demo of the config page:
Screen.Recording.2024-07-22.at.9.32.38.AM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes