Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Platform: Update Rust crate security-framework to v2.11.1 #10560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2024

This PR contains the following updates:

Package Type Update Change
security-framework (source) dependencies patch =2.11.0 -> =2.11.1

Release Notes

kornelski/rust-security-framework (security-framework)

v2.11.1

Compare Source


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner August 19, 2024 01:18
Copy link
Contributor Author

renovate bot commented Aug 19, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: apps/desktop/desktop_native/Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path apps/desktop/desktop_native/core/Cargo.toml --workspace
    Updating crates.io index
error: failed to select a version for `security-framework-sys`.
    ... required by package `security-framework v2.11.1`
    ... which satisfies dependency `security-framework = "=2.11.1"` of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
    ... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`
versions that meet the requirements `^2.11.1` are: 2.11.1

all possible versions conflict with previously selected packages.

  previously selected package `security-framework-sys v2.11.0`
    ... which satisfies dependency `security-framework-sys = "=2.11.0"` of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
    ... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`

failed to select a version for `security-framework-sys` which could resolve this conflict

@renovate renovate bot requested a review from coroiu August 19, 2024 01:18
@bitwarden-bot bitwarden-bot changed the title [deps] Platform: Update Rust crate security-framework to v2.11.1 [PM-11073] [deps] Platform: Update Rust crate security-framework to v2.11.1 Aug 19, 2024
@bitwarden-bot
Copy link

Internal tracking:

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.10%. Comparing base (ed4d481) to head (6ce5774).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10560   +/-   ##
=======================================
  Coverage   33.09%   33.10%           
=======================================
  Files        2683     2683           
  Lines       83563    83563           
  Branches    15877    15877           
=======================================
+ Hits        27658    27662    +4     
+ Misses      53726    53722    -4     
  Partials     2179     2179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [PM-11073] [deps] Platform: Update Rust crate security-framework to v2.11.1 [deps] Platform: Update Rust crate security-framework to v2.11.1 Aug 19, 2024
@dani-garcia
Copy link
Member

Just noticed that renovate split the security-framework and security-framework-sys updates in two PRs: this one and #10561.

So the break is because both versions need to be in sync, we should probably just add another group to the renovate config:

"groupName": "napi",
"matchPackageNames": ["napi", "napi-build", "napi-derive"]

@renovate renovate bot force-pushed the renovate/security-framework-2.x branch from 2d956f5 to c13da9a Compare September 5, 2024 10:56
@renovate renovate bot force-pushed the renovate/security-framework-2.x branch from c13da9a to 6ce5774 Compare September 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants