[PM-11503] Organization Automatic Sync verbiage is misleading #11151
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11151 +/- ##
==========================================
- Coverage 35.08% 33.17% -1.92%
==========================================
Files 2709 2727 +18
Lines 84530 85192 +662
Branches 16067 16208 +141
==========================================
- Hits 29661 28265 -1396
- Misses 53898 54675 +777
- Partials 971 2252 +1281 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
| "billingTokenSyncDesc": { | ||
| "message": "Billing sync unlocks Families sponsorships and automatic license syncing on your server. After making updates in the Bitwarden cloud server, select Sync License to apply changes." | ||
| }, |
There was a problem hiding this comment.
billingSyncDesc
There was a problem hiding this comment.
This message key is defined, but not used anywhere.
❓ Is it possible that billingSyncDescwas supposed to be replaced with billingTokenSyncDesc, but you then introduced automaticBillingSyncDescas the final replacement? If my assumption is correct, then please remove billingTokenSyncDescfrom en/messages.json
apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html
Show resolved
Hide resolved
apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html
Show resolved
Hide resolved
apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html
Show resolved
Hide resolved
| "billingTokenSyncDesc": { | ||
| "message": "Billing sync unlocks Families sponsorships and automatic license syncing on your server. After making updates in the Bitwarden cloud server, select Sync License to apply changes." | ||
| }, |
| "billingTokenSyncDesc": { | ||
| "message": "Billing sync unlocks Families sponsorships and automatic license syncing on your server. After making updates in the Bitwarden cloud server, select Sync License to apply changes." | ||
| }, |
There was a problem hiding this comment.
This message key is defined, but not used anywhere.
❓ Is it possible that billingSyncDescwas supposed to be replaced with billingTokenSyncDesc, but you then introduced automaticBillingSyncDescas the final replacement? If my assumption is correct, then please remove billingTokenSyncDescfrom en/messages.json
jonashendrickx
dismissed stale reviews from cturnbull-bitwarden and djsmith85
via
446c610
…omatic-Sync-verbiage-is-misleading-2' into PM-11503-Defect-Organization-Automatic-Sync-verbiage-is-misleading-2
jonashendrickx
dismissed stale reviews from amorask-bitwarden and djsmith85
via
213f9d3
jonashendrickx
deleted the
PM-11503-Defect-Organization-Automatic-Sync-verbiage-is-misleading-2
branch
🎟️ Tracking
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes