Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PM-11200] Move delete item permission to Can Manage (#10890)" #11155

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

gbubemismith
Copy link
Member

This reverts commit 8921230.

🎟️ Tracking

📔 Objective

Reverting this change as we have some defects and we need this feature on all clients.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.08%. Comparing base (01e530d) to head (88ebe18).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lt/components/vault-items/vault-items.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11155      +/-   ##
==========================================
+ Coverage   35.07%   35.08%   +0.01%     
==========================================
  Files        2710     2710              
  Lines       84550    84536      -14     
  Branches    16070    16065       -5     
==========================================
+ Hits        29656    29662       +6     
+ Misses      53923    53903      -20     
  Partials      971      971              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Logo
Checkmarx One – Scan Summary & Detailsf10ff2a9-9065-4f24-bae8-667e6d081019

No New Or Fixed Issues Found

shane-melton
shane-melton previously approved these changes Sep 19, 2024
@gbubemismith gbubemismith merged commit 7ae427e into main Sep 19, 2024
35 checks passed
@gbubemismith gbubemismith deleted the revert-merge-PM-11200 branch September 19, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants